Add @discardableResult to Scanner #1624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkera
approved these changes
Jul 10, 2018
|
@swift-ci please test |
|
@swift-ci please test and merge |
spevans
reviewed
Oct 10, 2018
Foundation/Scanner.swift
Outdated
| @@ -579,6 +589,7 @@ extension Scanner { | |||
| } | |||
| } | |||
|
|
|||
| @discardableString | |||
There was a problem hiding this comment.
Looks like a typo, should be @discardableResult.
There was a problem hiding this comment.
Oh. Really stupid typo. Fixed
On Darwin public methods with out parameters not produce "result call unused" warning So using @discardableResult here is behave more like Darwin Foundation
|
@millenomi Can you retest? |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@spevans seems something works wrong with |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Darwin public methods with out parameters not produce "result call unused" warning
So using @discardableResult here is behave more like Darwin Foundation