-
Notifications
You must be signed in to change notification settings - Fork 113
[examples] Add CDK deployment example #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One query around the manifest
] | ||
) | ||
|
||
if let localDepsPath = Context.environment["LAMBDA_USE_LOCAL_DEPS"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need all this for the example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so.
It allows the runtime developers to work on a development version of the runtime and test it with an example.
This is more for the convenience of the runtime developers.
It also allows the CI to run on the synced pair (runtime, examples). Otherwise, examples using the main
branch fetch a previous version at CI time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok sounds good
added an example showing how to deploy with the CDK
This code is the basis for the upcoming CDK section in the deployment guide