Skip to content

Add AWS SDK and Soto examples #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Oct 10, 2024
Merged

Add AWS SDK and Soto examples #396

merged 41 commits into from
Oct 10, 2024

Conversation

sebsto
Copy link
Contributor

@sebsto sebsto commented Oct 8, 2024

No description provided.

@sebsto sebsto requested a review from fabianfett October 8, 2024 18:57
fabianfett
fabianfett requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! First round of reviews.

@sebsto sebsto requested a review from fabianfett October 8, 2024 20:41
@sebsto
Copy link
Contributor Author

sebsto commented Oct 9, 2024

Waiting to land the CI change (#397) before merging this one.

I will need to add AWSSDK and SotoS3 to the examples_matrix.yml file

sebsto
sebsto commented Oct 10, 2024
View reviewed changes
Copy link
Contributor Author

@sebsto sebsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all changes are implemented

fabianfett
fabianfett reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we must fix the dependencies. Everything else is optional.

@fabianfett
Copy link
Member

please enable CI for the new examples :)

@sebsto
Copy link
Contributor Author

sebsto commented Oct 10, 2024

please enable CI for the new examples :)

I'm on it

fabianfett
fabianfett approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can fix everything left in follow ups, if we want to.

@sebsto sebsto merged commit b4673d2 into swift-server:main Oct 10, 2024
16 of 17 checks passed
@sebsto sebsto deleted the sebsto/awssdk_example branch October 10, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianfett fabianfett fabianfett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebsto @fabianfett