Skip to content

Move invalid value exception data to dedicated fields #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 29, 2021
Merged

Conversation

vearutop
Copy link
Member

@vearutop vearutop commented Aug 29, 2021

Fixes #126.
Fixes #127.

InvalidValue now exposes data and (optionally) expected value.

    public $constraint;
    public $data;

@github-actions
Copy link

github-actions bot commented Aug 29, 2021

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
JSON 22 (+1) 5316 (+22) 5316 (+22) 0 0 0 145.7K (+319B)
Markdown 2 630 (+9) 484 (+6) 0 146 (+3) 0 19.9K (+289B)
PHP 133 11143 (+55) 8065 (+44) 1481 (+8) 1597 (+3) 559 (+3) 322.6K (+2.3K)

@codecov
Copy link

codecov bot commented Aug 29, 2021

Codecov Report

Merging #128 (bdcc2f8) into master (8dbd73e) will increase coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head bdcc2f8 differs from pull request most recent head ef05a96. Consider uploading reports for the commit ef05a96 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #128      +/-   ##
============================================
+ Coverage     92.36%   92.53%   +0.16%     
- Complexity      760      764       +4     
============================================
  Files            27       27              
  Lines          1651     1688      +37     
============================================
+ Hits           1525     1562      +37     
  Misses          126      126              
Impacted Files Coverage Δ
src/InvalidValue.php 100.00% <100.00%> (ø)
src/Schema.php 96.10% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dbd73e...ef05a96. Read the comment docs.

@vearutop vearutop merged commit 1d7cce2 into master Aug 29, 2021
@vearutop vearutop deleted the error-data branch August 29, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multipleOf not always behaving correctly Export exception details in structured way
1 participant