-
-
Notifications
You must be signed in to change notification settings - Fork 115
chore(deps): update to eslint v9 #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand every config, but seems ok 😄
@benmccann does this look ok? esp. the integration of the svelte config? I am a bit surprised that it doesn't setup the ts parser, or does that work ootb now? |
oh, and it having browser and node globals enabled for everything by default is a bit lax too o_O |
Svelte and SvelteKit couldn't use it for awhile. It took quite a bit of work, but I just got those enabled recently, so yeah, we could look at moving those to the base config now: sveltejs/eslint-config#37 |
I don't remember how many places we'd need to enable them if they're not enabled globally or how hard that would be too do. We could investigate. As long as we don't make it so annoying that Rich rips out the whole eslint setup out of frustration 😆 |
yes, finding defaults that work for everyone can be a bit tricky. It's mostly .svelte files where i think it should be only browser globals by default. Maaaybe allow node globals in Lets discuss this over at the eslint-config repo? (Still getting the hang of eslint v9 config) |
…down thats already included in recommended config
used the migration tool but had to do a few changes after
The
node: false
in globals is replaced by a mapped 'off' spread, but that came after the browser spread, disabling shared globals in the process.todo: remove the FlatCompat helper