Skip to content

refactor: ts2jsdoc step2 #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/yellow-eggs-rush.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/vite-plugin-svelte': minor
---

refactor: release vite-plugin-svelte as unbundled javascript with jsdoc types
3 changes: 2 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ module.exports = {
ecmaVersion: 2020
},
rules: {
'n/no-unsupported-features/es-builtins': 'error',
'n/no-unsupported-features/es-syntax': 'error',
'no-console': 'off',
'no-debugger': 'error',
'n/no-missing-import': [
Expand Down Expand Up @@ -57,7 +59,6 @@ module.exports = {
],
'n/no-unpublished-import': 'off',
'n/no-unpublished-require': 'off',
'n/no-unsupported-features/es-syntax': 'off',
'no-process-exit': 'off'
},
overrides: [
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ jobs:
if: matrix.node == 14
run: pnpm install --no-frozen-lockfile --prefer-offline --ignore-scripts
- name: build
run: pnpm build:ci
run: pnpm build
- name: install playwright chromium
run: pnpm playwright install chromium
- name: run tests
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"private": true,
"scripts": {
"dev": "pnpm --dir packages/vite-plugin-svelte dev",
"build:ci": "pnpm --dir packages/vite-plugin-svelte build:ci",
"build": "pnpm --dir packages/vite-plugin-svelte build",
"test": "run-s -c test:unit test:build test:serve",
"test:unit": "vitest run",
Expand Down
7 changes: 0 additions & 7 deletions packages/e2e-tests/vitestGlobalSetup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,6 @@ const preserveArtifacts = !!process.env.TEST_PRESERVE_ARTIFACTS || isCI;

const DIR = path.join(os.tmpdir(), 'vitest_playwright_global_setup');

const buildPackagesUnderTest = async () => {
console.log('building packages');
await execa('pnpm', ['build:ci'], { stdio: 'inherit' });
console.log('building packages done');
};

const syncNodeModules = async () => {
// tests use symbolic linked node_modules directories. make sure the workspace is up for it
console.log('syncing node_modules');
Expand Down Expand Up @@ -50,7 +44,6 @@ export async function setup() {
console.log('');
console.log('preparing non ci env...');
await syncNodeModules();
await buildPackagesUnderTest();
console.log('preparations done');
}
console.log('Starting playwright server ...');
Expand Down
15 changes: 6 additions & 9 deletions packages/vite-plugin-svelte/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,20 @@
"license": "MIT",
"author": "dominikg",
"files": [
"dist",
"src",
"*.d.ts"
"src"
],
"type": "module",
"types": "dist/index.d.ts",
"types": "src/index.d.ts",
"exports": {
".": {
"types": "./dist/index.d.ts",
"import": "./dist/index.js"
"types": "./src/index.d.ts",
"import": "./src/index.js"
},
"./package.json": "./package.json"
},
"scripts": {
"dev": "pnpm build:ci --sourcemap --watch src",
"build:ci": "rimraf dist && tsup-node src/index.ts --format esm",
"build": "pnpm build:ci --dts --sourcemap",
"dev": "pnpm typecheck --watch",
"build": "pnpm typecheck",
"typecheck": "tsc --noEmit --allowJs --checkJs"
},
"engines": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export async function loadSvelteConfig(viteConfig, inlineOptions) {
try {
// identify which require function to use (esm and cjs mode)
const _require = import.meta.url
? (esmRequire ??= createRequire(import.meta.url))
? esmRequire ?? (esmRequire = createRequire(import.meta.url))
: require;

// avoid loading cached version on reload
Expand Down