Skip to content

fix: improve setup of default export and remove svelte/ssr #8516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 5, 2023
Merged

fix: improve setup of default export and remove svelte/ssr #8516

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
def6a45
fix: improve setup of default export
benmccann Apr 18, 2023
b674b89
remove svelte/ssr
benmccann Apr 18, 2023
01f3e02
update rollup
benmccann Apr 18, 2023
d996574
Merge branch 'version-4' into ssr-2
benmccann Apr 21, 2023
0aac48c
update changelog
benmccann Apr 21, 2023
f39085f
oops. a word
benmccann Apr 21, 2023
a0cad8b
link PRs
benmccann Apr 21, 2023
61eb0b7
Update CHANGELOG.md
benmccann Apr 24, 2023
ed4e62b
Update CHANGELOG.md
benmccann Apr 26, 2023
7bae717
revert dumb changes
benmccann May 5, 2023
42412e0
revert whitespace change
benmccann May 5, 2023
8987345
add another note to the changelog
benmccann May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@

## Unreleased (4.0)

* **breaking** Minimum supported Node version is now Node 14
* **breaking** Minimum supported webpack version is now webpack 5
* **breaking** Minimum supported TypeScript version is now TypeScript 5 (it will likely work with lower versions, but we make no guarantees about that)
* **breaking** Minimum supported Node version is now Node 14 ((#8482)[https://github.com/sveltejs/svelte/pull/8482])
* **breaking** Minimum supported webpack version is now webpack 5 ((#8515)[https://github.com/sveltejs/svelte/pull/8515])
* **breaking** Minimum supported vite-plugin-svelte version is now 2.1.0. SvelteKit users can upgrade to 1.15.8 to ensure a compatible version ((#8516)[https://github.com/sveltejs/svelte/pull/8516])
* **breaking** Minimum supported TypeScript version is now TypeScript 5 (it will likely work with lower versions, but we make no guarantees about that) ((#8488)[https://github.com/sveltejs/svelte/pull/8488])
* **breaking** Stricter types for `createEventDispatcher` (see PR for migration instructions) ([#7224](https://github.com/sveltejs/svelte/pull/7224))
* **breaking** Stricter types for `Action` and `ActionReturn` (see PR for migration instructions) ([#7224](https://github.com/sveltejs/svelte/pull/7224))
* **breaking** Stricter types for `onMount` - now throws a type error when returning a function asynchronously to catch potential mistakes around callback functions (see PR for migration instructions) ([#8136](https://github.com/sveltejs/svelte/pull/8136))
Expand Down
13 changes: 2 additions & 11 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,8 @@
"import": "./index.mjs",
"require": "./index.js"
},
"node": {
"import": "./ssr.mjs",
"require": "./ssr.js"
},
"import": "./index.mjs",
"require": "./index.js"
"import": "./ssr.mjs",
"require": "./ssr.js"
},
"./compiler": {
"types": "./types/compiler/index.d.ts",
Expand Down Expand Up @@ -78,11 +74,6 @@
},
"./elements": {
"types": "./elements/index.d.ts"
},
"./ssr": {
"types": "./types/runtime/index.d.ts",
"import": "./ssr.mjs",
"require": "./ssr.js"
}
},
"engines": {
Expand Down
5 changes: 1 addition & 4 deletions rollup.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ export default [
{
input: {
...runtime_entrypoints,
index: 'src/runtime/index.ts',
ssr: 'src/runtime/ssr.ts'
index: 'src/runtime/index.ts'
},
output: ['es', 'cjs'].map(
/** @returns {import('rollup').OutputOptions} */
Expand All @@ -50,8 +49,6 @@ export default [
entryFileNames: (entry) => {
if (entry.isEntry) {
if (entry.name === 'index') return `index.${ext}`;
else if (entry.name === 'ssr') return `ssr.${ext}`;

return `${entry.name}/index.${ext}`;
}
},
Expand Down