-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat: improve types for createEventDispatcher
#7224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dummdidumm
merged 15 commits into
sveltejs:version-4
from
ivanhofer:createEventDispatcher-types
Apr 14, 2023
Merged
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c17384b
improve types for `createEventDispatcher`
ivanhofer 22aa51d
allow optional parameters for `createEventDispatcher`
ivanhofer 5491871
replace `undefined` with `null`
ivanhofer a4f151b
Merge branch 'master' into createEventDispatcher-types
ivanhofer f50219a
revert formatting changes
ivanhofer ba35fae
fix types
ivanhofer 28c3508
fix no payload case
ivanhofer cd24b6a
remove test code
ivanhofer 2425851
revert formatting changes
ivanhofer 234f9f6
revert formatting changes
ivanhofer 61be96e
Merge branch 'version-4' into createEventDispatcher-types
dummdidumm 8d57674
simplify type, add tests
dummdidumm 4f795e9
changelog
dummdidumm 4e9fea6
Merge branch 'version-4' into createEventDispatcher-types
dummdidumm 0411851
fix ci
dummdidumm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.