-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[feat] action types #7121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[feat] action types #7121
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
09fb497
action interfaces
ignatiusmb 87469bd
ignore build output
ignatiusmb aaf0bf4
allow void return
ignatiusmb f66e2c3
package exports map
ignatiusmb e31a7cd
make parameters optional, allow empty `use:action`
ignatiusmb 336872d
allow Element to be inferred and constrained
ignatiusmb c7adb02
make parameters in update optional too
ignatiusmb 1614bdc
revert optional parameters in update
ignatiusmb ae01d6a
reverse the order of generics
ignatiusmb 2372b6e
actually only 1 and avoid conflict with TS utility
ignatiusmb 5ac1868
docs
dummdidumm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,7 @@ node_modules | |
/compiler.*js | ||
/index.*js | ||
/ssr.*js | ||
/action | ||
/internal | ||
/store | ||
/easing | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
export interface ActionReturn<Parameters = any> { | ||
update?: (parameters: Parameters) => void; | ||
destroy?: () => void; | ||
} | ||
|
||
export interface Action<Parameters = any> { | ||
(node: HTMLElement, parameters: Parameters): void | ActionReturn<Parameters>; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.