Upgrade to TypeScript 4 #5746
Closed
Upgrade to TypeScript 4 #5746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That lint error needs to be ignored because the generics need to match between interface and class I think. |
|
One disadvantage of bumping TS is that we might accidentally use type constructs introduced in later versions which forces TS users to bump their version of TS which might be interpreted as a breaking change. |
|
Ah, I had been thinking that any differences from TypeScript features would disappear after the code is compiled, but I suppose there's some risk that someone uses a new feature in a I'll close in favor of #5747 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just keeping things a bit more up-to-date