Skip to content

Fixes a11y warning in 06-select-bindings tutorial #5037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

gsimone
Copy link

@gsimone gsimone commented Jun 18, 2020

The Select Bindings examples shows an accessibility warning:

A11y: on:blur must be used instead of on:change, unless absolutely necessary and it causes no negative consequences for keyboard only or screen reader users. (24:1)

@Conduitry
Copy link
Member

I think we probably want to figure out what to do with #4946 before doing something like this. Changing from on:change to on:blur results in different behavior, and I think we should first decide what we want the warning to be exactly, and when it should appear.

@gsimone
Copy link
Author

gsimone commented Jun 23, 2020

I agree, although using on:blur doesn't really make a difference in the context of the example, it's just something that - looks - like a user error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants