-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
chore: remove options.uid in render() #15302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Despite it not being public API I think we still need a change set for this then we are good to go |
🦋 Changeset detectedLatest commit: 3b344a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Done ;) |
To solve a bug in Astro: withastro/astro#13327 we need access to this API, can we add it back? I wouldn't mind sending PR. |
Yes it seems that it is required for your case. Note that I'm not sure if this API worked. But since this would become a public API, the maintainers' opinion is required... |
@adiguba I've asked in the discord and @dummdidumm gave me the go ahead, I'll link this issue when I have something working. |
When I write #15185 I have added an options on the
render()
function, allowing to pass a custom uid-generator.I totally forgot to mention it on the PR, and now I think that it is useless and should not be there.
This option is not documented and not declared in typescript definition of
render()
.So I think it's better to remove it.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint