Skip to content

fix: prevent a11y_label_has_associated_control false positive for component in <label> #12119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/swift-rats-sing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"svelte": patch
---

fix: prevent `a11y_label_has_associated_control` false positive for component or render tag in `<label>`
2 changes: 2 additions & 0 deletions packages/svelte/src/compiler/phases/2-analyze/a11y.js
Original file line number Diff line number Diff line change
Expand Up @@ -1086,6 +1086,8 @@ function check_element(node, state) {
if (
node.type === 'SvelteElement' ||
node.type === 'SlotElement' ||
node.type === 'Component' ||
node.type === 'RenderTag' ||
(node.type === 'RegularElement' &&
(a11y_labelable.includes(node.name) || node.name === 'slot'))
) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
<script>
import Component from './component.svelte'
</script>

<label>
<slot />
</label>

<label>
<Component />
</label>
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<script>
import Component from './component.svelte'
</script>

<label>
{@render x()}
</label>
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[]
Loading