-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat: make render
options optional
#12111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
00f5f03
feat: make `render` options optional
Rich-Harris 7865ddc
Merge branch 'main' into optional-render-options
Rich-Harris d5f673a
oops
Rich-Harris 9d4111a
more accurate types
dummdidumm 79bdf99
same for mount/hydrate
dummdidumm 8ce0a54
Apply suggestions from code review
dummdidumm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'svelte': patch | ||
--- | ||
|
||
feat: make `render` options optional | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import type { RenderOutput } from '#server'; | ||
import type { ComponentProps, Component, SvelteComponent, ComponentType } from 'svelte'; | ||
|
||
/** | ||
* Only available on the server and when compiling with the `server` option. | ||
* Takes a component and returns an object with `body` and `head` properties on it, which you can use to populate the HTML when server-rendering your app. | ||
*/ | ||
export function render< | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. had to move this into a |
||
Comp extends SvelteComponent<any> | Component<any>, | ||
Props extends ComponentProps<Comp> = ComponentProps<Comp> | ||
>( | ||
...args: {} extends Props | ||
? [ | ||
component: Comp extends SvelteComponent<any> ? ComponentType<Comp> : Comp, | ||
options?: { props?: Omit<Props, '$$slots' | '$$events'>; context?: Map<any, any> } | ||
] | ||
: [ | ||
component: Comp extends SvelteComponent<any> ? ComponentType<Comp> : Comp, | ||
options: { props: Omit<Props, '$$slots' | '$$events'>; context?: Map<any, any> } | ||
] | ||
): RenderOutput; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,5 @@ | ||
// @ts-ignore | ||
import { render } from 'svelte/server'; | ||
// @ts-ignore you need to create this file | ||
import App from './App.svelte'; | ||
|
||
// @ts-ignore | ||
export const { head, body, css } = render(App, { props: { initialCount: 0 } }); | ||
export const { head, body } = render(App); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.