Skip to content

docs: explain prop update breaking change #11548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented May 10, 2024

extracting this out of #11495 since it's unrelated. fixes #11448

Copy link

changeset-bot bot commented May 10, 2024

⚠️ No Changeset found

Latest commit: 77bd52e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gterras
Copy link

gterras commented May 10, 2024

I believe this fixes #11448 ?

@Rich-Harris
Copy link
Member Author

indeed it does — thanks!

@dummdidumm
Copy link
Member

I honestly have no idea how this ended up in the other PR. Probably a quick draft I wrote and accidentally committed.
Still want to quickly see whether it's feasible to fix this in legacy mode.

@Rich-Harris
Copy link
Member Author

Definitely feasible, we'd just need to create deriveds for member expressions as well as expressions involving function calls

@Rich-Harris
Copy link
Member Author

Opened #11571 which implements the fix, meaning legacy mode components continue to work the same way. We still need this PR though, since the behaviour changes in runes mode (unless we wanted to wrap props in deriveds more aggressively there too, but I don't think we do)

@dummdidumm
Copy link
Member

Closing since we merged the fix

@dummdidumm dummdidumm closed this May 14, 2024
@dummdidumm dummdidumm deleted the prop-update-behaviour-docs branch May 14, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: store updates trigger component prop changes that didn't with 4
3 participants