-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
breaking: add $bindable() rune to denote bindable props #10851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 23 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
001a831
add $props.bindable()
dummdidumm e98c242
compile time mutation validation
dummdidumm 7557c8f
fix
dummdidumm f05e1db
regenerate
dummdidumm 376898f
runtime error when trying to bind: to non-bindable prop
dummdidumm 0bcc55d
sigh
dummdidumm e17e5e7
Merge branch 'main' into props-bindable
dummdidumm 695a309
remove compiler error due to potential of false positives
dummdidumm a472ccf
error on rest prop and duplicate props
dummdidumm efcc5ac
revert duplicate prop name validation (valid use cases exist)
dummdidumm 4d92bfb
fix
dummdidumm b0a8aaf
more fixes
dummdidumm 17b916c
fix another edge case
dummdidumm cc90ffa
woops
dummdidumm 4f97639
regenerate
dummdidumm ed670eb
Merge branch 'main' into props-bindable
dummdidumm 84e2dd3
make it a dev-time validation error that also deals with ...rest props
dummdidumm 1d81838
allow rest props on $props.bindable() and add related dev time valida…
dummdidumm 6f274ac
tweak
dummdidumm 6f8a451
Merge branch 'main' into props-bindable
dummdidumm 6d6e94c
breaking: add `$bindable()` rune to denote bindable props
dummdidumm 017db61
code mirror
dummdidumm 7992ef8
tweak docs
dummdidumm ef0bc44
Apply suggestions from code review
dummdidumm 62c39ee
Merge branch 'main' into props-bindable-2
dummdidumm 6ea89a3
args validation
dummdidumm adc3f7a
bindable location fix + test
dummdidumm 8ad1b98
feat: include rest props object name in error message (#10868)
Rich-Harris 34d9a59
doh
dummdidumm bf0a830
lint
dummdidumm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.