svelte 5 : Attribute values containing {...} must be enclosed in quote marks, unless the value only contains the expression
#12466
Assignees
Comments
5 tasks
dummdidumm
added a commit
that referenced
this issue
Jul 17, 2024
Trailing comments were added even if they started before the node end, which violates the definition of trailing comments. This fixes that, with the consequence that some comments no longer show up in the AST at all. Previously they were stuffed _somewhere_, but arguably at the wrong positions. For example the last comment in a function body got assigned as a trailing comma for the body, which is wrong, because the body ends _after_ the comma. The special case is comments at the end of an expression tag - they are added even if there are multiple, and they are added regardless of whether they are separated by newlines or not. This ensures the expression tag end is calculated correctly. Fixes #12466
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Attribute values containing
{...}must be enclosed in quote marks, unless the value only contains the expressionwhen we have comment in handler, it errorrs
Reproduction
https://svelte-5-preview.vercel.app/#H4sIAAAAAAAACo2OTQ6CMBCFrzKZuAAlQXSHQOI5rAusQ9IIU0KnJqbp3U1h4dblfG_eT8DBjOSwvgXkfiKs8TrPWKB85nS4N41CWKCzftGJNE4vZpZOsZKRBLT1LNDCzkkvlB3zi-KkDZ61GMtgWC80EUuWQ0iKks1zaKG6bKDcA1Sn86k6w75MKCpuyl8TNw8vYhks69HoVxuyvO3-TItxHbsaXQ1h_V8LttAOC5zs0wyGnljL4ine4xdIOcThGQEAAA==
Logs
No response
System Info
Severity
annoyance
The text was updated successfully, but these errors were encountered: