Skip to content

Remove prepublish minification #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
larrybotha opened this issue Jul 6, 2020 · 2 comments
Closed

Remove prepublish minification #194

larrybotha opened this issue Jul 6, 2020 · 2 comments
Assignees
Labels
next-major will be fixed in the next major

Comments

@larrybotha
Copy link

Is your feature request related to a problem? Please describe.

Debugging transformations in a project when svelte-preprocesss source is minified is challenging.

Describe the solution you'd like

Remove minification step from prePublishOnly script

How important is this feature to you?

Minor. It's a minor inconvenience that svelte-preprocesss source is minified, as I'm not going to interact with it regularly.

Additional context

Is svelte-preprocess used in the browser anywhere? I'm unaware of any use-cases where it would be, but if it is, then I understand the need for minification, although minification is often left up to the user.

If it's not being used as a client-side library, then I'd recommend removing the minification, as there's little need for minifying Node modules, and it makes it straightforward for users to debug issues in their build configs.

@kaisermann kaisermann added the next-major will be fixed in the next major label Jul 6, 2020
@kaisermann
Copy link
Member

kaisermann commented Jul 6, 2020

Hey @larrybotha 👋 I totally feel your point and it makes complete sense. As v4 is right around the corner, I'll be removing the minification step from there!

Edit:

Released v4.0.0-alpha.2 with no minification 😁

@kaisermann kaisermann self-assigned this Jul 6, 2020
kaisermann added a commit that referenced this issue Jul 6, 2020
@larrybotha
Copy link
Author

@kaisermann now that's great customer support \ :D /

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-major will be fixed in the next major
Projects
None yet
Development

No branches or pull requests

2 participants