-
-
Notifications
You must be signed in to change notification settings - Fork 23
docs: rewrite parser config docs to mainly use flat config #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pull Request Test Coverage Report for Build 9010065864Details
💛 - Coveralls |
Do we need to care that making confusion for users who cannot yet use flat confog? |
Hmm. I personally want Svelte users to use flat configs. That's because I think Svelte users prefer ESM. (Legacy JS config format only supports commonjs.) |
My suggestion is to put both configs in the README for a while. |
I will do that 👍 |
For example: | ||
|
||
```json | ||
{ | ||
"parser": "svelte-eslint-parser", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ask]
Is it ok to lose this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we limit the explanation to parserOptions
, the same explanation can be given for both configs, so we have removed the description specific to the legacy config.
} | ||
``` | ||
|
||
#### Parser Object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ask]
Can we remove this section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the explanation of eslint.config.js
uses the parser object, there is no need to explain it again, so I removed it. I added that feature for support for eslint.config.js
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
No description provided.