Skip to content

chore: update PostCSS and tests #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

baseballyama
Copy link
Member

I created this PR because eco-system-ci is failed.
https://github.com/sveltejs/svelte-ecosystem-ci/actions/runs/5483027087/jobs/9994935125

After investigation, I found that this was due to a change in the order of JSON properties when postcss 8.4.25 was released.
I think we can not say that this was not a bug, so I simply upgraded the postcss version and fixed tests.

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2023

⚠️ No Changeset found

Latest commit: 1b29541

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@baseballyama
Copy link
Member Author

I think we don't need a changeset for this?

@Conduitry
Copy link
Member

How are the actual results being compared with these JSON files? The better solution seems to me to be to make that comparison able to deal with keys in different orders.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Ordering issues may cause problems again, but I think the changes in this PR are fine now so I'm merging this.

@ota-meshi ota-meshi merged commit 02f9d87 into sveltejs:main Jul 7, 2023
@baseballyama
Copy link
Member Author

Currently, JSON is mainly compared as a string. I implemented the process of sorting JSON properties before create this PR, but since it has some performance impact and situations like this do not occur often, So I simply updated tests.
If this happens again, I will add this process and then compare them as JSON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants