fix: pass options to silence warning #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikg
reviewed
Mar 2, 2023
| @@ -95,7 +95,7 @@ module.exports = function (options = {}) { | |||
| return path.resolve(dir, pkg.svelte); | |||
| } | |||
|
|
|||
| const resolved = await this.resolve(importee, importer, { skipSelf: true }); | |||
| const resolved = await this.resolve(importee, importer, { skipSelf: true, ...options }); | |||
There was a problem hiding this comment.
not sure if legal to pass in from the outside, but to prevent endless loop it would be better to put skipSelf: true after the spread
Suggested change
| const resolved = await this.resolve(importee, importer, { skipSelf: true, ...options }); | |
| const resolved = await this.resolve(importee, importer, { ...options, skipSelf: true }); |
There was a problem hiding this comment.
looks like Lukas himself suggested putting it in front, so feel free to ignore this lightyen/typescript-paths#3 (comment)
dominikg
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #207