break: remove old-compiler interop #142
Conversation
|
I vote yes on removing .html from the default extensions. svelte.root was part of an old feature to export multiple components from one package. This was later discouraged in favor of just having pkg.svelte point at a .js file that reexports multiple components. |
|
Thanks, means we can dump both of those :D Also, third question: remove |
|
shared should also be removed, yeah, as that was a Svelte 1+2 thing, and Svelte only returns things that use the shared helpers and that need to be run through a bundler. There needs to remain some mechanism for handling and displaying compiler warnings, as the compiler just returns them in an array in v3 and doesn't print them. |
| fixed_options.shared = require.resolve(options.shared || 'svelte/shared.js'); | ||
| } | ||
| /** @type {import('svelte/types/compiler/interfaces').ModuleFormat} */ | ||
| const format = 'esm', config = { format }; |
There was a problem hiding this comment.
I wonder if eslint would allow this. We should probably set that up at some point too
There was a problem hiding this comment.
We already have ESLint running. It's fine with it. TBH I only did this because this irks me:
/** @type {import('svelte/types/compiler/interfaces').ModuleFormat} */
const format = 'esm';
const config = { format };
There was a problem hiding this comment.
Why isn’t this just
const config = { format: 'esm' };There was a problem hiding this comment.
Because intellisense complains about it at the compiler(code, { ...config, }) spot, saying that format: string does not align with format: ModuleFormat type.
There's no technical reason or anything – it's just so that there are no red squiggles on the page
|
Merging with 2 approvals, ty |
Removed roughly ~100 lines of code 🙌
[email protected]code branches~!async/awaitinside transform hook)Questions:
.htmldefault extension?We strongly(?) discourage this now.
svelte.rootstuff?Holding this in "Draft" state until we decide on these answers.