Skip to content

fix(types): allow css: false option #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2020
Merged

fix(types): allow css: false option #125

merged 1 commit into from
Sep 8, 2020

Conversation

lukeed
Copy link
Member

@lukeed lukeed commented Aug 28, 2020

readme declares css: false but types disallowed it

@benmccann
Copy link
Member

This looks fine to me. Or alternatively we could update the readme? It'd save us from having to cut a new release. I think that not providing css (i.e. css: undefined) is equivalent to css: false

@lukeed
Copy link
Member Author

lukeed commented Aug 28, 2020

This needs to be here either way -- otherwise IDE yells about invalid option(s)
The official template also uses css: boolean and is "an error" by default.

Also, versions are cheap -- especially patches.

@Conduitry Conduitry merged commit c5dae70 into master Sep 8, 2020
@Conduitry Conduitry deleted the types/option-css branch September 8, 2020 12:50
@lukeed
Copy link
Member Author

lukeed commented Sep 8, 2020

Thanks~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants