Skip to content

breaking: new options, deprecate svelteStrictMode #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 17, 2023

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jul 14, 2023

  • whether or not empty elements/components should self-close is now left to the user - in other words, if you write <div /> or <Component /> that stays as is, and so does <div></div>/<Component></Component>. svelteStrictMode only has effect on elements (not allowing self-closing non-void-ones)
  • svelteAllowShorthand now takes precedence over svelteStrictMode, which no longer has any effect on that behavior

closes #284
closes #279
closes #238
related to #348
related to #377
superseeds / closes #379 as less options = better

dummdidumm and others added 6 commits December 11, 2022 21:30
* refactor: Remove deprecated concat

* Remove Concat node checks
Updates the code base to using prettier v3. This required a refactoring of embeds since the call timing is now different

---------

Co-authored-by: Simon H <[email protected]>
Co-authored-by: Rolaka <[email protected]>
Co-authored-by: Simon Holthausen <[email protected]>
- whether or not empty elements/components should self-close is now left to the user - in other words, if you write `<div />` or `<Component />` that stays as is, and so does `<div></div>`/`<Component></Component>`. `svelteStrictMode` no longer has any effect on this behavior
- `svelteAllowShorthand` now takes precedence over `svelteStrictMode`, which no longer has any effect on that behavior
- `svelteStrictMode` is deprecated as future Svelte versions might coerce numbers coming from mustache tags inside strings into strings

closes #348
closes #284
closes #279
closes #238
related to #377
superseeds / closes #379 as less options = better
@dummdidumm dummdidumm changed the base branch from next to master July 17, 2023 10:29
@dummdidumm dummdidumm merged commit 23f3dc4 into master Jul 17, 2023
@dummdidumm dummdidumm deleted the self-close-approach-2 branch July 17, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants