Skip to content

Remove use of concat() #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove use of concat() #276

wants to merge 1 commit into from

Conversation

fisker
Copy link

@fisker fisker commented Feb 8, 2022

Leftover from #223

@dummdidumm
Copy link
Member

dummdidumm commented Feb 8, 2022

This would be a breaking change because older versions of Prettier (below 2.3 AFAIK) do not support using an array instead of concat - we therefore would need to bump peer dependency requirements. Does Prettier remove support for using concat now or why is this change needed?

@fisker
Copy link
Author

fisker commented Feb 8, 2022

Ah, I misunderstood #223, it handles new concat(array) from core parsers, not removing concat().

I'm planning to remove concat() in Prettier v3.0.0, if you are going to support older versions of Prettier, we should keep them.

I got some time today, I was checking plugins listed on Prettier website, I thought it's better to help you remove use of concat() before we release v3 (we don't have a schedule yet, maybe longer than I expect).

Feel free to close.

@dummdidumm
Copy link
Member

Thanks for the clarification! I'll keep this open as a reminder. As soon as Prettier 3.0 is released I'll remove concat and release a new major version of prettier-plugin-svelte 👍

@fisker
Copy link
Author

fisker commented Feb 8, 2022

FYI: There is also an ESLint plugin can do this job, eslint-plugin-prettier-doc.

@dummdidumm
Copy link
Member

Closing in favor of #334

@dummdidumm dummdidumm closed this Dec 11, 2022
@fisker fisker deleted the concat branch December 12, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants