Skip to content

Fix missing initial state of updated store tutorial #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

salman-ar-sar
Copy link

This PRs fixes the initial state missing issue on Part 3: Basic SvelteKit > Stores > Updated store tutorial.

It didn't have an initial state and stayed in the solved state.

@vercel
Copy link

vercel bot commented Aug 10, 2023

@salman-ar-sar is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@dummdidumm
Copy link
Member

Tricky one - the problem with this tutorial is that it's not really possible to see the result as it would require a new version of learn.svelte.dev to be available. So this tutorial chapter just talks about how this looks like - but the git diff certainly makes it look like you would have to do something. Mhm..

@salman-ar-sar
Copy link
Author

Tricky one - the problem with this tutorial is that it's not really possible to see the result as it would require a new version of learn.svelte.dev to be available. So this tutorial chapter just talks about how this looks like - but the git diff certainly makes it look like you would have to do something. Mhm..

Oh yeah that makes sense. But the tutorial shows the change and makes it look I should make that change. Comparing it with the previous tutorials made me think like that.

But what you said makes sense, so what should we do?

@Rich-Harris
Copy link
Member

thank you. i don't think there's an ideal solution to this, but i think #544 is probably as close as we can get for now — it basically solves the 'what changed?' problem by inverting it. i'll close this in favour of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants