chore: improve detection of iOS devices #391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomoam is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
|
This is probably no longer needed since #395 |
|
Thanks!! |
|
@benmccann Nevertheless, this PR has conflicts, so I will create another PR again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #306 (comment)
As noted in #306 (comment), I feel it would be better to let the user know about it and give them the option to run it or not, similar to Stackblitz. And this PR implements it.
If the user's device OS is iOS/iPad OS and Safari is 16.4 or higher, the following will be displayed:
If the 'Run the tutorial' button is pressed, Webcontainer will be booted.