Skip to content

feat!: drop support for old eslint #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2024
Merged

feat!: drop support for old eslint #937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34dc64d
feat!: drop support for old eslint
ota-meshi Nov 28, 2024
4df8ae9
add changeset
ota-meshi Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cool-rockets-allow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'eslint-plugin-svelte': major
---

feat!: drop support for old eslint
9 changes: 2 additions & 7 deletions .github/workflows/NodeCI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
eslint: [7, 8, 9]
eslint: [8, 9]
node: [18.x, 20.x, 22.x, latest]
steps:
- name: Checkout
Expand Down Expand Up @@ -126,13 +126,8 @@ jobs:
with:
node-version: ${{ matrix.node }}
- name: Install svelte@3
# Remove @sveltejs/kit because postinstall fails on old node.
run: |
cd docs-svelte-kit
pnpm rm @sveltejs/kit
cd ..
pnpm install -D -w @typescript-eslint/parser@5 @typescript-eslint/eslint-plugin@5 eslint@8
cd packages/eslint-plugin-svelte
cd ./packages/eslint-plugin-svelte
pnpm install -D svelte@3
cd ../..
rm -rf packages/eslint-plugin-svelte/node_modules
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ npm install --save-dev eslint eslint-plugin-svelte svelte

> **Requirements**
>
> - ESLint v7.0.0 and above
> - Node.js v14.17.x, v16.x and above
> - ESLint v8.57.1, v9.0.0 and above
> - Node.js v18.20.4, v20.18.0, v22.10.0 and above

<!--DOCS_IGNORE_END-->

Expand Down
4 changes: 2 additions & 2 deletions docs/user-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ npm install --save-dev eslint eslint-plugin-svelte svelte

::: tip Requirements

- ESLint v7.0.0 and above
- Node.js v14.17.x, v16.x and above
- ESLint v8.57.1, v9.0.0 and above
- Node.js v18.20.4, v20.18.0, v22.10.0 and above

:::

Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin-svelte/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"version:ci": "env-cmd -e version-ci pnpm run update && changeset version"
},
"peerDependencies": {
"eslint": "^7.0.0 || ^8.0.0-0 || ^9.0.0-0",
"eslint": "^8.57.1 || ^9.0.0",
"svelte": "^3.37.0 || ^4.0.0 || ^5.0.0"
},
"peerDependenciesMeta": {
Expand Down
Loading