Skip to content

fix: optional param to open new files with code #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 36 additions & 5 deletions packages/eslint-plugin-svelte/tools/new-rule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { writeAndFormat } from './lib/write';
const logger = console;

// main
void (async (ruleId) => {
void (async ([ruleId, ...args]) => {
if (ruleId == null) {
logger.error('Usage: pnpm run new <RuleID>');
process.exitCode = 1;
Expand Down Expand Up @@ -130,12 +130,43 @@ This rule reports ???.
`
);

cp.execSync(`code "${ruleFile}"`);
cp.execSync(`code "${testFile}"`);
cp.execSync(`code "${docFile}"`);
})(process.argv[2]);
const { code } = expectedArgs(args);
if (!code) {
return;
}

try {
// Use code -v to know if vscode is installed and do not print anything to the console
cp.execSync('code -v', { stdio: 'ignore' });
cp.execSync(`code "${ruleFile}"`);
cp.execSync(`code "${testFile}"`);
cp.execSync(`code "${docFile}"`);
} catch (_) {
logger.error('Unable to find code command. Will not open files with VSCode.');
}
})(process.argv.slice(2));

/** Get module path */
function getModulePath(from: string, module: string): string {
return path.relative(path.dirname(from), module).replace(/.ts$/u, '');
}

/** Argument parsing */
function expectedArgs(args: string[]) {
const result = { code: false };

for (let i = 0; i < args.length; i++) {
const arg = args[i];
const split = args[i].split('=');
if (arg === '--code') {
// Passing --code alone is the same as --code=true
result.code = args[i + 1] === 'true' || args[i + 1] === undefined;
} else if (split.length === 2) {
result.code = split[1] === 'true';
} else if (split.length > 2) {
logger.error('Usage: pnpm run new <RuleID> <--code=boolean>');
}
}

return result;
}
Loading