Skip to content

chore: migrate to monorepo #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 8, 2024
Merged

chore: migrate to monorepo #759

merged 19 commits into from
Jun 8, 2024

Conversation

baseballyama
Copy link
Member

@baseballyama baseballyama commented May 12, 2024

WIP. Still there are a lot of todos.
-> I will continue work on next weekend. (18th, 19th May)

Copy link

changeset-bot bot commented May 12, 2024

⚠️ No Changeset found

Latest commit: 4425571

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@baseballyama baseballyama force-pushed the chore/monorepo branch 3 times, most recently from ad907d3 to 1fc37f1 Compare May 12, 2024 08:07
@baseballyama baseballyama force-pushed the chore/monorepo branch 12 times, most recently from 570b4c3 to aea38f7 Compare May 12, 2024 10:26
@baseballyama baseballyama force-pushed the chore/monorepo branch 6 times, most recently from 97e837a to 16a9a77 Compare May 19, 2024 14:56
@baseballyama
Copy link
Member Author

@ota-meshi Almost done but ota-meshi/vite-plugin-eslint4b#51 and ota-meshi/vite-plugin-eslint4b#53 are blocker.
I will do self-review for this but I don't have confident that changeset release works properly or not😅

@baseballyama
Copy link
Member Author

@ota-meshi

I need your help!
Still I can not build docs project due to file path mismatch.

2024-06-08.10.28.24-1.mov

I think ota-meshi/vite-plugin-eslint4b#55 breaks this. But I'm not sure how to solve the issue. Maybe we can revert I think ota-meshi/vite-plugin-eslint4b#55 or you have better idea.

@ota-meshi
Copy link
Member

I think ota-meshi/vite-plugin-eslint4b#55 breaks this.

Hmm... It was a CI error so I made some changes. I will check out this branch later and give it a try.

@ota-meshi
Copy link
Member

ota-meshi commented Jun 8, 2024

I fixed vite-plugin-eslint4b and I think the build script is passing. However, the playground launched by the dev script still doesn't work. I don't know what the difference is yet...

@baseballyama
Copy link
Member Author

@ota-meshi

Thank you for fixing this!
As far as I know, the dev command is not working properly on the main branch either.
So I think we can merge this PR after completing the following tasks:

  • Ensuring that the release process is not broken (since CI cannot check this, we need to verify it manually)
  • Conducting a general code review

@baseballyama
Copy link
Member Author

This is not related to this PR, but do you think it is possible to convert the documentation project to ESM?
There are plans to consolidate Svelte-related documentation into a single omnisite, which will need to be migrated to ESM before this can be done.

@baseballyama baseballyama marked this pull request as ready for review June 8, 2024 06:28
@ota-meshi
Copy link
Member

This is not related to this PR, but do you think it is possible to convert the documentation project to ESM?

Yes, I believe we can migrate our documentation to the ESM project.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for doing a great job!

@ota-meshi ota-meshi merged commit 74e0f0b into main Jun 8, 2024
13 checks passed
@ota-meshi ota-meshi deleted the chore/monorepo branch June 8, 2024 07:35
@baseballyama
Copy link
Member Author

Hum...

image

@baseballyama
Copy link
Member Author

I'm fixing.

@baseballyama
Copy link
Member Author

@baseballyama
Copy link
Member Author

And I confirmed that the site is working properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants