chore: fix tests to follow latest Svelte 5 #751
Conversation
|
|
So, I think sveltejs/svelte#11327 changes messages, so messages between Svelte 4 and Svelte 5 is not same anymore. |
baseballyama
changed the title
|
We need to wait to solve this issue.
|
baseballyama
changed the title
baseballyama
force-pushed
the
chore/fix-ci
branch
3 times, most recently
from
4383b3a to
8155033
Compare
| @@ -128,7 +128,8 @@ const config = [ | |||
| }, | |||
| rules: { | |||
| 'n/file-extension-in-import': 'off', | |||
| 'n/no-unsupported-features/es-syntax': 'off' | |||
| 'n/no-unsupported-features/es-syntax': 'off', | |||
| 'n/no-unsupported-features/es-builtins': 'off' | |||
There was a problem hiding this comment.
I needed to disable n/no-unsupported-features/es-builtins for window.btoa.
| <a href="#" on:click={(evt) => onClickMessage(evt, msg)} class="message-link" | ||
| >[{msg.line}:{msg.column}]</a | ||
| >: | ||
| <button on:click={(evt) => onClickMessage(evt, msg)} class="message-link"> |
There was a problem hiding this comment.
I resolved the warning.
I just added Node 22 but CI does not pass in #750
sveltejs/svelte#11327 changes warning messages, so I mainly copied exist tests and optimized for Svelte 5.