fix: handle type aliases for $$Slots and $$Events related rules #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 81c5363 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pawelblaszczyk5
force-pushed
the
component-types-with-alias
branch
from
8640811 to
81c5363
Compare
ota-meshi
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
Currently these two rules
experimental-require-strict-events,experimental-require-slot-typeswhich assert existence of $$Slots/$$Events handles interface declarations only. However, Svelte Language Server works with type aliases as well. I added an option that will catch them when they're declared as type aliases. I also added failing tests, before implementing fixes.I'm also wondering whether the wording e.g.
The component must define the $$Slots interfaceshould be adjusted?Closes #528