Skip to content

feat(no-unused-class-name): added a whitelist option #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 28, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/beige-jobs-travel.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-plugin-svelte": minor
---

feat(no-unused-class-name): added a whitelist option
13 changes: 12 additions & 1 deletion docs/rules/no-unused-class-name.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,18 @@ This rule is aimed at reducing unused classes in the HTML template. While `svelt

## :wrench: Options

Nothing.
```json
{
"svelte/no-unused-class-name": [
"error",
{
"allowedClassNames": ["class-name-one", "class-name-two"]
}
]
}
```

- `allowedClassNames` ... A list of class names that shouldn't be reported by this rule. Default `[]`.

## :rocket: Version

Expand Down
21 changes: 19 additions & 2 deletions src/rules/no-unused-class-name.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,28 @@ export default createRule("no-unused-class-name", {
category: "Best Practices",
recommended: false,
},
schema: [],
schema: [
{
type: "object",
properties: {
allowedClassNames: {
type: "array",
items: {
type: "string",
},
},
},
additionalProperties: false,
},
],
messages: {},
type: "suggestion",
},
create(context) {
if (!context.parserServices.isSvelte) {
return {}
}
const allowedClassNames = context.options[0]?.allowedClassNames ?? []
const classesUsedInTemplate: Record<string, SourceLocation> = {}

return {
Expand All @@ -52,7 +66,10 @@ export default createRule("no-unused-class-name", {
? findClassesInPostCSSNode(styleContext.sourceAst)
: []
for (const className in classesUsedInTemplate) {
if (!classesUsedInStyle.includes(className)) {
if (
!allowedClassNames.includes(className) &&
!classesUsedInStyle.includes(className)
) {
context.report({
loc: classesUsedInTemplate[className],
message: `Unused class "${className}".`,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"options": [{ "allowedClassNames": ["div-class"] }]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- message: Unused class "span-class".
line: 3
column: 1
suggestions: null
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<div class="div-class">Hello</div>

<span class="span-class">World!</span>
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"options": [{ "allowedClassNames": ["div-class", "span-class"] }]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<div class="div-class">Hello</div>

<span class="span-class">World!</span>