-
-
Notifications
You must be signed in to change notification settings - Fork 48
all
config
#407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all
config
#407
Conversation
🦋 Changeset detectedLatest commit: 9513d2e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8ce0a79
to
4c107cf
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document the caveats as mentioned in the issue. I think we also need to export from index.ts. Also we need to resolve the CI (linting) error.
added the documentation and the export. as for the CI error, i have no idea what's going on. as far as i can tell it's unrelated because locally when i run the tests after reverting my changes the errors still occur |
Thank you for the PR. As you said, the remaining CI errors appear unrelated to the changes in the PR. I will look into the cause later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
fixes #369