Skip to content

fix: types of isOptionableExpression #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

baseballyama
Copy link
Member

I run yarn build on the latest main branch, but command failed due to type error.
Therefore I fixed it up.

baseballyama@baseballyama eslint-plugin-svelte % yarn build
yarn run v1.22.19
$ yarn clean
$ rimraf .nyc_output lib coverage build .svelte-kit svelte.config-dist.js
$ yarn build:ts
$ tsc --project ./tsconfig.build.json
src/rules/@typescript-eslint/no-unnecessary-condition.ts:749:34 - error TS2345: Argument of type 'ArrayExpression | ArrayPattern | ArrowFunctionExpression | AssignmentExpression | AwaitExpression | ... 35 more ... | YieldExpression' is not assignable to parameter of type 'LeftHandSideExpression'.
  Type 'AssignmentExpression' is not assignable to type 'LeftHandSideExpression'.
    Type 'AssignmentExpression' is missing the following properties from type 'TSTypeAssertion': typeAnnotation, expression

749       if (isOptionableExpression(nodeToCheck)) {
                                     ~~~~~~~~~~~


Found 1 error in src/rules/@typescript-eslint/no-unnecessary-condition.ts:749

@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2022

⚠️ No Changeset found

Latest commit: 03f555b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit 420dba2 into sveltejs:main Dec 29, 2022
@baseballyama baseballyama deleted the fix/types branch December 29, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants