-
-
Notifications
You must be signed in to change notification settings - Fork 48
fix isKitPageComponent
on windows
#318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 589a696 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Thank you for your contribution! Could you please add a changeset? |
Should we add mac/windows CI? |
@baseballyama i can't get the changeset command to run on my PC.
would you mind doing it for me? thanks |
nvm i just made the file manually |
@DetachHead Thank you for the PR! The changes you made look good to me.
As you said, it would be better if there were tests for each platform. |
it always returned
false
on windows because file paths are separated by\
instead of/