feat: add svelte/prefer-destructured-store-props rule
#270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Editor doesn't like this but maybe it's ok?
Also add a description
🦋 Changeset detectedLatest commit: 5de72f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tivac
approved these changes
Oct 5, 2022
| object: TSESTree.Identifier & { name: string } | ||
| } | ||
|
|
||
| const keywords = new Set([ |
There was a problem hiding this comment.
Would something like esutils be useful here since it's less likely to drift out of sync?
There was a problem hiding this comment.
Thank you for checking this PR. I think it would be great to replace with esutils as you suggested! I will change this PR.
tivac
approved these changes
Oct 6, 2022
JounQin
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up for #208.
Changed the rule to only warn about store property access in templates.
close #208