Skip to content

chore: update design #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2022
Merged

chore: update design #256

merged 2 commits into from
Sep 20, 2022

Conversation

baseballyama
Copy link
Member

related: #253

I updated below points.

  • Fix background color -> I stop to use gradation.
  • change header behavior like SvelteKit web site -> Now header has fixed position.
  • Left side scroll bar's color. (Maybe SvelteKit web site7s color is better?) -> I followed Svelte docs color.

I'm not designer, so I don't have ability to create good design, but I think this PR is bit improved.
I'm open for your opinion.

image

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2022

⚠️ No Changeset found

Latest commit: 24b0812

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 20, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@@ -6,7 +6,7 @@
--font-mono: "Fira Mono", monospace;
--pure-white: #ffffff;
--primary-color: #b9c6d2;
--secondary-color: #d0dde9;
--secondary-color: #676778;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--secondary-color is not used at all. So I updated this color according to Svelte site7s color.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job! Thank you!

@ota-meshi ota-meshi merged commit ee2c344 into sveltejs:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants