Skip to content

test: ignore indent test for decorators with ts4.8 #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2022
Merged

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Aug 30, 2022

It seems there was a breaking change in decorator nodes in ts4.8. Because of this some tests using typescript-eslint v4 fail so ignoring these tests.


It also fixes yarn install in codesandbox-ci failing because svelte kit no longer supports Node v16.13.

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2022

⚠️ No Changeset found

Latest commit: edaeba5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@ota-meshi ota-meshi merged commit 20dd202 into main Aug 30, 2022
@ota-meshi ota-meshi deleted the dev-for-ts-4.8 branch August 30, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants