feat: implement stores-no-async
#225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0b8b4ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
baseballyama
commented
Aug 14, 2022
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
8 tasks
ota-meshi
requested changes
Aug 15, 2022
src/rules/no-store-async.ts
Outdated
| if (name !== "writable" && name !== "readable" && name !== "derived") | ||
| return | ||
| const [, fn] = node.arguments | ||
| if (fn.type !== "ArrowFunctionExpression" || !fn.async) return |
There was a problem hiding this comment.
I think we should check if the argument exists.
Suggested change
| if (fn.type !== "ArrowFunctionExpression" || !fn.async) return | |
| if (!fn || fn.type !== "ArrowFunctionExpression" || !fn.async) return |
There was a problem hiding this comment.
fixed! Sorry for that!
|
Thank you for your review! |
tivac
approved these changes
Aug 22, 2022
JounQin
approved these changes
Aug 22, 2022
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #198 (
stores-no-async)This is the first ESLint rule I have written.
(So I'm sorry if I have a wrong understanding.)
I would be very grateful if you would review it.