-
-
Notifications
You must be signed in to change notification settings - Fork 48
feat(html-self-closing): add configuration presets #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(html-self-closing): add configuration presets #216
Conversation
*sorry for the amount of commits this PR is going to have. I'm in an environment where I can't install packages, so I can't use type checking, code formatting etc. |
@ota-meshi @JounQin could you please generate errors.json & output.svelte for the preset tests? I won't be able to do so until saturday / sunday. I've checked |
I don't have time right now, I'd like to try when I'm free. 🍺 |
The PR is ready! Once the invalid test outputs are generated and verified, it can be merged! |
🦋 Changeset detectedLatest commit: 88ea618 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request introduces 1 alert when merging 49da137 into 931c062 - view on LGTM.com new alerts:
|
We are about to introduce changeset and lgtm into this repository, but have not configured it yet. Ignore these messages for now. |
I've updated the rule to take either a preset enum or config object, which makes this PR non-breaking |
Right, so the PR description should be updated. 😁 |
@ota-meshi @JounQin what do you think about the |
According to Angular's HTML parser playground, |
I've realised the test outputs the errors, so I've copied it into the test output files, so the tests should pass now |
so many typos lmao 😂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your efforts!
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
see #190 (comment)
Changes
html-self-closing
added preset configuration option
current presets:
* to be discussed whether svelte elements should or shouldn't be self closing in html-compliant preset.
Progressthis PR is still a draft,html-self-closing
tests are still using the old configuration, no preset tests have been added and the documentation forhtml-self-closing
rule is also outdates