Skip to content

Add svelte/require-stores-init rule #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 7, 2022
Merged

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Aug 5, 2022

This PR adds svelte/require-stores-init rule that require initial value in store.

This rule was taken from @tivac/svelte/stores-initial-value rule.
However, no suggestions are provided.
The original suggestion is to give false as the argument, but I think the least code-breaking suggestion is to give undefined as the argument. But for most users it makes no sense to give undefined.

@ota-meshi ota-meshi requested a review from tivac August 5, 2022 11:55
@ota-meshi ota-meshi marked this pull request as ready for review August 5, 2022 11:55
@ota-meshi ota-meshi force-pushed the require-stores-initial branch from 0560139 to f9dbca9 Compare August 6, 2022 14:38
@ota-meshi ota-meshi merged commit 119e4af into main Aug 7, 2022
@ota-meshi ota-meshi deleted the require-stores-initial branch August 7, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants