Skip to content

Add svelte/no-reactive-literals rule #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 31, 2022

Conversation

tivac
Copy link
Collaborator

@tivac tivac commented Jul 29, 2022

Porting over another of the simpler rules from https://github.com/tivac/eslint-plugin-svelte/ like we discussed in #198

@tivac
Copy link
Collaborator Author

tivac commented Jul 30, 2022

Had to add some infrastructure to make snapshot testing of suggestions possible, will be useful for #201 as well.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 4947459 into sveltejs:main Jul 31, 2022
@tivac tivac deleted the no-reactive-literals branch July 31, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants