chore: use context.cwd
#1176
Merged
chore: use context.cwd
#1176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 80dd3f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
43081j
force-pushed
the
compat-gone
branch
2 times, most recently
from
fb385e2 to
a7267b7
Compare
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
|
weirdly this CI failure doesn't seem related but im not sure why else it'd be happening 🤔 |
Switches to using `context.cwd` since all ESLint versions we support now have it. The previously used `getCwd` helper falls back to `process.cwd()` (which ESLint itself doesn't do). So in the few places we relied on that, a fall back to `process.cwd()` has been added.
|
it was me being blind. we still depend on the compat package for the rule tester |
|
@43081j Will you make a 1 more PR for |
|
i was looking at that, i feel like we should be able to drop most of it (or all of it?) i'll see where i get with it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to using
context.cwdsince all ESLint versions we support now have it.The previously used
getCwdhelper falls back toprocess.cwd()(which ESLint itself doesn't do). So in the few places we relied on that, a fall back toprocess.cwd()has been added.This is the last remaining compat function, so we have also dropped theeslint-compat-utilsdependency.