-
-
Notifications
You must be signed in to change notification settings - Fork 48
chore: use context.sourceCode
instead of compat
#1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As of 3.x, we only support `8.57.1` and `>=9.0.0` of ESLint. Both of these have `context.sourceCode` available, so we should no longer need the `getSourceCode` compat helper. The helper does polyfill some missing methods but `8.57.1` seems to have all of those already.
🦋 Changeset detectedLatest commit: 889f5bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your Local
Published Instant Preview Packages:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update packages/eslint-plugin-svelte/eslint.config.mjs
line number 73?
i had the same thought and just made the change as you wrote that, in the other PR too 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
As of 3.x, we only support
8.57.1
and>=9.0.0
of ESLint.Both of these have
context.sourceCode
available, so we should no longer need thegetSourceCode
compat helper.The helper does polyfill some missing methods but
8.57.1
seems to have all of those already.