Skip to content

feat: add fixer for no-at-debug-tags #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 29, 2025

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Mar 28, 2025

Adds a simple fixer which removes the debug node.

Adds a simple fixer which removes the debug node.
Copy link

changeset-bot bot commented Mar 28, 2025

⚠️ No Changeset found

Latest commit: a69b07c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 28, 2025

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@1164

Published Instant Preview Packages:

View Commit

@baseballyama
Copy link
Member

For example, in my case, I automatically run ESLint fixers with format on save.
If the {@debug} tag gets removed during that process, it effectively makes the {@debug} tag unusable.
Therefore, I believe having a fixer would actually be inconvenient.

I think it would be better to make it a suggestion, similar to the no-console rule:
https://eslint.org/docs/latest/rules/no-console

@43081j
Copy link
Contributor Author

43081j commented Mar 29, 2025

I don't mind either way. If your usage is the common use case, I'm happy to change it to a suggestion

@baseballyama
Copy link
Member

@43081j I would appreciate it if you could make it a suggestion.

@43081j
Copy link
Contributor Author

43081j commented Mar 29, 2025

i've updated it to be a suggestion 👍

Copy link
Collaborator

@JounQin JounQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is broken due to related document unchanged.

@baseballyama
Copy link
Member

baseballyama commented Mar 29, 2025

Can you add a changeset?

Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baseballyama baseballyama merged commit 29b1315 into sveltejs:main Mar 29, 2025
17 checks passed
@43081j 43081j deleted the fixer-debug-tags branch March 29, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants