feat: set languageOptions.globals
in base config
#1038
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint-plugin-svelte
's config does not havelanguageOptions.globals
.https://github.com/sveltejs/eslint-plugin-svelte/blob/main/packages/eslint-plugin-svelte/src/configs/flat/base.ts
I think many Svelte applications require
globals.browser
, so is it worth providing it in the base config?references:
docs-svelte-kit
setglobals.browser
: https://github.com/sveltejs/eslint-plugin-svelte/blob/main/docs-svelte-kit/eslint.config.mjs#L34eslint-plugin-vue
providesglobals.browser
in base config: https://github.com/vuejs/eslint-plugin-vue/blob/master/lib/configs/flat/base.js#L17