feat: add Svelte 5 support to no-not-function-handler
#1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e0b77ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
ota-meshi
reviewed
Jan 14, 2025
| @@ -95,6 +95,18 @@ export default createRule('no-not-function-handler', { | |||
| return; | |||
| } | |||
| verify(node.expression); | |||
| }, | |||
| SvelteAttribute(node) { | |||
| if (node.key.type === 'SvelteName' && node.key.name.startsWith('on')) { | |||
There was a problem hiding this comment.
I don't know if that's actually the case, but I'm worried that there might be false positives for components with properties like one, only, once, and online. 🤔
I think maybe we should ignore component attributes from the check. What do you think?
There was a problem hiding this comment.
Yes. We need to take every events from here.
https://github.com/sveltejs/svelte/blob/a129592e5b248a734a68da6e9028941803a3d063/packages/svelte/elements.d.ts#L83
baseballyama
force-pushed
the
feat/no-not-function-handler
branch
from
f7a3556 to
1266f5b
Compare
baseballyama
force-pushed
the
feat/no-not-function-handler
branch
from
2e2b6f0 to
e0b77ba
Compare
This was referenced Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated docs also. (
on:click->onclick)