Skip to content

Refactor: Use "@typescript-eslint/types" instead of "estree" for node type checking. #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ota-meshi opened this issue Nov 2, 2022 · 0 comments · Fixed by #294
Closed

Refactor: Use "@typescript-eslint/types" instead of "estree" for node type checking. #293

ota-meshi opened this issue Nov 2, 2022 · 0 comments · Fixed by #294

Comments

@ota-meshi
Copy link
Member

Originally we used only estree, but since we started handling TypeScript nodes in rules, We also use @typescript-eslint/types.
Now the mix confuses type checking.
We should remove estree from dependencies and refactor to use @typescript-eslint/types instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use @typescript-eslint/types instead of estree sveltejs/eslint-plugin-svelte
1 participant
@ota-meshi