wip: feedback

Author: tivac

src/rules/prefer-reactive-destructuring.ts

@@ -41,9 +41,8 @@ export default createRule("prefer-reactive-destructuring", {
           loc: node.loc,
           messageId: "useDestructuring",
           suggest:
-            // Don't show suggestions for entries like $: info = foo.bar.info, the destructuring
-            // just looks too gross and complicates the rule too much
-            right.object.type === "MemberExpression"
+            // Don't show suggestions for complex right-hand values, too tricky to get it right
+            right.object.type !== "Identifier" || right.computed
               ? []
               : [
                   {

tests/fixtures/rules/prefer-reactive-destructuring/invalid/test01-errors.json

@@ -7,7 +7,7 @@
       {
         "desc": "Use destructuring to get finer-grained redraws",
         "messageId": "suggestDestructuring",
-        "output": "<!-- prettier-ignore -->\n<script>\n    $: ({ info } = foo)\n    $: bar = foo.something\n    $: baz = foo.bar.baz\n</script>\n"
+        "output": "<!-- prettier-ignore -->\n<script>\n    $: ({ info } = foo)\n    $: bar = foo.something\n    $: baz = foo.bar.baz\n    $: qux = foo[bar]\n    $: dux = foo.baz().bar\n</script>\n"
       }
     ]
   },
@@ -19,7 +19,7 @@
       {
         "desc": "Use destructuring to get finer-grained redraws",
         "messageId": "suggestDestructuring",
-        "output": "<!-- prettier-ignore -->\n<script>\n    $: info = foo.info\n    $: ({ something: bar } = foo)\n    $: baz = foo.bar.baz\n</script>\n"
+        "output": "<!-- prettier-ignore -->\n<script>\n    $: info = foo.info\n    $: ({ something: bar } = foo)\n    $: baz = foo.bar.baz\n    $: qux = foo[bar]\n    $: dux = foo.baz().bar\n</script>\n"
       }
     ]
   },
@@ -28,5 +28,17 @@
     "line": 5,
     "column": 8,
     "suggestions": null
+  },
+  {
+    "message": "Prefer destructuring in reactive statements",
+    "line": 6,
+    "column": 8,
+    "suggestions": null
+  },
+  {
+    "message": "Prefer destructuring in reactive statements",
+    "line": 7,
+    "column": 8,
+    "suggestions": null
   }
 ]

tests/fixtures/rules/prefer-reactive-destructuring/invalid/test01-input.svelte

@@ -3,4 +3,6 @@
     $: info = foo.info
     $: bar = foo.something
     $: baz = foo.bar.baz
+    $: qux = foo[bar]
+    $: dux = foo.baz().bar
 </script>